Add tags and tickets fields to get cases request #5564
Merged
+323
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, I don't think we want to do it this way. When include is supported: dispatch/src/dispatch/case/views.py Line 125 in 7bc0a67 We create a special result set using: We should figure out a way to support nested objects via that function such that additionally nested fields can be gathered as well. This would also solve the problem across the incident, case and task apis. Lmk if you want to pair on that approach, it's been a long time since I looked at that code and it's sort of magical. |
whitdog47
approved these changes
Dec 3, 2024
kevgliss
approved these changes
Dec 12, 2024
metroid-samus
deleted the
enhancement/include-case-tag-ticket-fields-in-get-cases
branch
metroid-samus
added a commit
that referenced
this pull request
Dec 12, 2024
* Add tags and tickets fields to get cases request * Attempt to move include parameter in GET requests to Cases into database service. * Adding tests * Adding tests * Add tags and ticket fields back to CaseReadMinimal * Switch test from Incident to Case. * remove duplicates * Fix unused variable assignment * Fixing tests --------- Co-authored-by: kevgliss <[email protected]> Co-authored-by: Kevin Glisson <[email protected]>
metroid-samus
added a commit
that referenced
this pull request
Dec 16, 2024
* Allow export of tag fields for Incidents and Cases. * Add tags and tickets fields to get cases request (#5564) * Add tags and tickets fields to get cases request * Attempt to move include parameter in GET requests to Cases into database service. * Adding tests * Adding tests * Add tags and ticket fields back to CaseReadMinimal * Switch test from Incident to Case. * remove duplicates * Fix unused variable assignment * Fixing tests --------- Co-authored-by: kevgliss <[email protected]> Co-authored-by: Kevin Glisson <[email protected]> * Export tags as tag_type.name/tag.name * Preview case tag column as 'tag_type.name/tag.name' --------- Co-authored-by: kevgliss <[email protected]> Co-authored-by: Kevin Glisson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.